Anyone want to help privacytools.io with some somewhat tedious tasks? 😆
I'm trying to add i18n support to the site so we can get some translations up! But it means I need pretty much every English string to be copied to a separate file to be translated. Info @ https://github.com/privacytoolsIO/privacytools.io/issues/1106
@jonah, I can help. can you give permission to me to check in? I made a small edit to browser-addon.html and the en.yml. If that is correct I'll keep at it.
my git hub ID is @yeet647.
@Yeet can't find your account: https://github.com/yeet647 (?)
Do you know how the pull request functionality works? If so you can submit PRs to the i18n branch on the repo and I'll merge them in ASAP 😃
@Yeet seems like it! I'm not actually able to add users to push to this repository but if you do your work in a fork I can merge your commits in to the branch 😃
@jonah - hey, thanks for patience. I'm new to this.
Check out change below and make sure I have the pattern correct. If so I will continue my cut and paste mastery to support the cause.
https://github.com/yeet648/privacytools.io/commit/9ce7ec2882b04fa8f841ab4416a12da74f8de69f
@Yeet 🙏 Thanks! Two quick things. 1) I want to use underscores instead of dashes/spaces in en.yml. 2) I forgot to mention and this is my bad but the {%t tags don't actually work in the include cards.
Take a look at what I did here to work around that (https://github.com/privacytoolsIO/privacytools.io/blob/i18n/_includes/sections/resources.html#L5) and then here (https://github.com/privacytoolsIO/privacytools.io/blob/i18n/_includes/sections/resources.html#L21) and tell me if that makes any sense to you. I'll add that info to the issue page.
@jonah thanks for the example. I think I got it and will give this another try.
@Yeet I updated the issue if that's more helpful at all. Otherwise this is fantastic! Thank you for helping out 😃 I would have been very sad if I had to do *everything* myself lol
@jonah I wrapped up browser-addons page - https://github.com/yeet648/privacytools.io/commit/e099c33ae9fd9426b8dfc0e93861494e61d42216
What is best way for me to notify you as I complete additional pages?
I'll keep fetching from the i18n branch to pick up other changes
@Yeet thank you! You’re wonderful lol
You can either leave a comment on this issue and I’ll handle it when I get a chance:
https://github.com/privacytoolsIO/privacytools.io/issues/1106
Or, you can open a Pull Request here:
https://github.com/privacytoolsIO/privacytools.io/pulls (when you do so, make sure you change the branch from “master” to “i18n” at the top, like the screenshot in my issue).
@jonah I’ll follow up with the pull requests. I should have some more updates tomorrow.
@jonah hi - can you update issue 1106 with the pages that still need to strings replaced with tokens? I'm ready to support the cause with my copy/paste skills.
i see some of the pages, like android add on, are makred as needed tokens in the issue check list, but the source file looks like it's already been tokenized.
@jonah btw - I found some pages that need tending to. I'll resume with the self contrained network and self hosted cloud pages.
@Yeet updated! I think that was the only one that hadn't been checked off. I'll also bring the i18n branch up-to-date with master in a couple minutes.
@jonah - is this any better - https://github.com/yeet648?